From b2691aee386b18425a7b96cca05e3bcceb8678ae Mon Sep 17 00:00:00 2001 From: Phil Elwell Date: Fri, 17 Apr 2020 16:20:55 +0100 Subject: [PATCH] Revert "firmware: raspberrypi: register clk device" This reverts commit 91f2cf4a6b2131016b1ae9c9500245f0572112c7. Revert this because the clock driver won't probe without a DT node, and creating it as a platform device won't give it one. Doing so avoids the following error message: raspberrypi-clk raspberrypi-clk: Missing firmware node Signed-off-by: Phil Elwell --- drivers/firmware/raspberrypi.c | 10 ---------- 1 file changed, 10 deletions(-) --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c @@ -22,7 +22,6 @@ #define MBOX_CHAN_PROPERTY 8 static struct platform_device *rpi_hwmon; -static struct platform_device *rpi_clk; struct rpi_firmware { struct mbox_client cl; @@ -302,12 +301,6 @@ rpi_register_hwmon_driver(struct device } } -static void rpi_register_clk_driver(struct device *dev) -{ - rpi_clk = platform_device_register_data(dev, "raspberrypi-clk", - -1, NULL, 0); -} - static void rpi_firmware_delete(struct kref *kref) { struct rpi_firmware *fw = container_of(kref, struct rpi_firmware, @@ -365,7 +358,6 @@ static int rpi_firmware_probe(struct pla rpi_firmware_print_firmware_revision(fw); rpi_firmware_print_firmware_hash(fw); rpi_register_hwmon_driver(dev, fw); - rpi_register_clk_driver(dev); return 0; } @@ -386,8 +378,6 @@ static int rpi_firmware_remove(struct pl platform_device_unregister(rpi_hwmon); rpi_hwmon = NULL; - platform_device_unregister(rpi_clk); - rpi_clk = NULL; rpi_firmware_put(fw); g_pdev = NULL;